Merged
Conversation
WalkthroughBump to v1.2.43: update Ably Android dependency to 1.6.0, bump package and README references to 1.2.43, and adjust Android-only realtime test expected channel-state sequence (remove duplicate 'attached' and drop 'update' event). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Around line 3-7: Replace the incorrect artifact name "ably-java" with
"ably-android" in the changelog entry so it matches the actual Maven artifact
used and prior entries; edit the line "- Updated `ably-java` dependency to
`1.6.0`" to read "- Updated `ably-android` dependency to `1.6.0`" referencing
the CHANGELOG.md entry text so consistency is preserved with
android/build.gradle and previous releases.
2d3b0ef to
1a06d07
Compare
…s different expected values for iOS and Android (update reduces number of differences), created issue to investigate ably/ably-java#1186
1a06d07 to
7538199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ably-javadependency to1.6.0Summary by CodeRabbit
Chores
Documentation
Tests
✏️ Tip: You can customize this high-level summary in your review settings.