Open
Conversation
maratal
force-pushed
the
fix/533-dont-request-push-token
branch
from
71b24d0 to
4709101
Compare
maratal
force-pushed
the
fix/533-dont-request-push-token
branch
from
4709101 to
cbeaea0
Compare
…ocoa and received by flutter, which sends it to ably via the first available `ARTRealtime` object. All instances have the same value for the `device.push` property, since the `device` itself is stored in a static variable.
maratal
force-pushed
the
fix/533-dont-request-push-token
branch
from
cbeaea0 to
25ef834
Compare
ttypic
reviewed
Jul 29, 2024
…moteNotificationsWithDeviceToken` on a proper instance of the realtime/rest that called push activation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary push token handling. Token is requested by ably-cocoa and received by flutter, which sends it to ably via the
ARTRealtimeobject, through which the token was requested.Closes #533