chore: clean up the fork, make it work without expo #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please briefly explain the main changes in this PR that make it platform agnostic? From what I can see the implementation itself was already agnostic and didn't rely on any specific Expo APIs, so the only part that this PR cuts out is the build process using |
VeskeR
reviewed
Jan 7, 2026
VeskeR
reviewed
Jan 7, 2026
VeskeR
reviewed
Jan 7, 2026
VeskeR
reviewed
Jan 7, 2026
VeskeR
suggested changes
Jan 7, 2026
VeskeR
left a comment
VeskeR
left a comment
There was a problem hiding this comment.
LGTM overall.
Couple of minor comments above, and suggestion regarding eslint not present in the diff:
.eslintrc.js - should remove this file as well (currently using default config from expo modules), or ideally set up a different default lint rules and add lint script.
Co-authored-by: Andrew Bulat <andrii.bulat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up the fork, make it work without expo