Rails 8 Support #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request introduces several breaking and compatible changes to modernize the gem and remove legacy dependencies. The main focus is on dropping HAML support, updating Rails and Ruby compatibility, and simplifying the codebase and test matrix.
Compatibility and dependency updates:
.github/workflows/test.ymlis simplified to only test supported Ruby/Rails combinations, removing all HAML-related gemfiles and legacy Rails versions. [1] [2]Codebase and documentation simplification:
lib/angular_xss/erb.rbto use a simpler, modern approach for patching ERB escaping, and addedescape_if_unsafeto centralize escaping logic. [1] [2]Other improvements:
CHANGELOG and metadata updates:
CHANGELOG.mddocuments all breaking and compatible changes, including the removal of HAML support and new Rails compatibility.These changes modernize the gem, reduce maintenance overhead, and make it easier to use with recent Rails and Ruby versions.
Compatibility and dependency updates
Codebase and documentation simplification
lib/angular_xss/erb.rbfor modern Rails patching and centralized escaping logic. [1] [2]Other improvements
CHANGELOG and metadata updates
CHANGELOG.mdand gem metadata to reflect all breaking and compatible changes. [1] [2]