fixed unbound function to prevent click function#70
Open
fabioformosa wants to merge 1 commit intoabhikmitra:masterfrom
Open
fixed unbound function to prevent click function#70fabioformosa wants to merge 1 commit intoabhikmitra:masterfrom
fabioformosa wants to merge 1 commit intoabhikmitra:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prevent-click function, bound by joyride, persists also after joyride closed. Inspecting $fkEl, I noticed that off function, called to remove stopEvent, doesn't effect because the function returned by angular.bind it's not the same. (Bug detected with angular 1.2.28 and jquery 2.1.1)
I've opened issue #71 with plunkr to reproduce bug and fix.