Conversation
piyush0609
reviewed
Jan 13, 2019
spec/matrix_spec.rb
Outdated
| it "returns [1, 2] as the first row of the matrix \n1 2\n10 20" do | ||
| matrix = Matrix.new("1 2\n10 20") | ||
| expect(matrix.extract_row(0)).to eq([1, 2]) | ||
| expect(matrix.extract_row(0)).to eq([1 , 2]) |
piyush0609
reviewed
Jan 13, 2019
spec/matrix_spec.rb
Outdated
| end | ||
|
|
||
| it "returns [] as the second column of the non-regular matrix\n10 19 15\n11 13 16" do | ||
| it "returns [19, 13] as the second column of the non-regular matrix\n10 19 15\n11 13 16" do |
There was a problem hiding this comment.
Test case description can be improved. Avoid including details about test data in description.
spec/matrix_spec.rb
Outdated
| context "when extracting a column of a matrix" do | ||
| it "returns [1 , 10] as the first column of the matrix \n1 2\n10 20" do | ||
| matrix = Matrix.new("1 2\n10 20") | ||
| expect(matrix.extract_column(0)).to eq([1 , 10]) |
Collaborator
There was a problem hiding this comment.
format should be consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.