Fix domain grouping for sites with country-code TLDs (e.g., .co.uk) and more #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes an issue where the tab grouping feature was not correctly handling sites with country-code top-level domains (TLDs) like .co.uk and .com.br. The logic for generating group names has been improved to handle country-code TLDs by:
Removing the www prefix from domain names.
Correctly handling country-code TLDs (e.g., .co.uk, .com.br).
Removing common TLDs (e.g., .com, .net, .org, .cn etc.) from the domain name.
Ensuring the main domain is extracted for tab grouping.
genGroupNamefunction to improve domain extraction..co.uk,.com.br).