Consolidate run commands into a single layer#44
Open
danrubins wants to merge 1 commit intoabernix:masterfrom
danrubins:single-layer-base-install
Open
Consolidate run commands into a single layer#44danrubins wants to merge 1 commit intoabernix:masterfrom danrubins:single-layer-base-install
danrubins wants to merge 1 commit intoabernix:masterfrom
danrubins:single-layer-base-install
Conversation
By putting the cleanup script in the same layer as the install script, we can avoid persisting temporary filesystem changes in the intermediate layers
Owner
|
This is great! Given my comments on #43, do you know which of these makes the more substantial improvement? I'm pretty sure we could make tremendous improvements by switching to multi-stage Docker builds, if you were willing to take a look at that. Given its popularity, I think improving this image is very much welcomed and I thank you for looking into it. Though I will be honest, I have a lot of respect for the image produced by https://github.com/disney/meteor-base, which offers a lot in terms of improvement since it doesn't try to be a compatibility fix for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By putting the cleanup script in the same layer as the install script, we can avoid persisting temporary filesystem changes in the intermediate layers. Between this and #43, it trims the image size by about a third.