fix: restore initial dimensions and placeholder on application restart#708
Draft
Kasui92 wants to merge 1 commit intoabenz1267:masterfrom
Draft
fix: restore initial dimensions and placeholder on application restart#708Kasui92 wants to merge 1 commit intoabenz1267:masterfrom
Kasui92 wants to merge 1 commit intoabenz1267:masterfrom
Conversation
Kasui92
force-pushed
the
fix-race-condition
branch
from
6060419 to
83f1d90
Compare
Kasui92
force-pushed
the
fix-race-condition
branch
from
0a87fa5 to
487e59f
Compare
Author
|
Updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be transparent, I got help from Claude Code for this fix, so consider this a suggestion rather than the definitive solution.
Unfortunately, I can't figure it out without it, and I'm still not sure if it's a problem with me (perhaps related to some configuration or GNOME) or a logical one.
I apologize if there are any suboptimal choices. I'll just leave the suggestion, hoping to address this difficulty.
When using
walkeras a--gapplication-service, closing and immediately reopening with different--maxheight/--minheightvalues causes the second invocation to be silently capped to the dimensions of the first.Capture the true XML defaults once at window creation time and store them in WindowData.
This fix seems to work on GNOME 48 (Debian Trixie), but not on GNOME 46 (Ubuntu 24.04).
Closes #703