Conversation
leonardodiasb
left a comment
leonardodiasb
left a comment
There was a problem hiding this comment.
Required Changes ♻️ ⚠️ 🚦
Hi @abel-tefera,
Good job so far!
You still need to work on some issues to go to the next project, but you are almost there!
Good points 👍
- No linter errors. ✔️
- Correct use of GitHub flow. ✔️
Aspects to improve ♻️
- Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Hello Microverse</title> | ||
| </head> | ||
| <body> | ||
| <h1 class="header">Hello,</h1> | ||
| </body> |
There was a problem hiding this comment.
- You correctly created the CSS file, but the color is not being added to the 'Hello' text because it is not being imported by the HTML file. Kindly import the styles from the CSS file in the
headof theindex.htmlfile and make sure that the styling is being applied.
README.md
Outdated
| > A simple project. | ||
|
|
||
| **Hello Microverse Project** is a... | ||
|
|
||
| ## 🛠 Built With <a name="built-with"></a> | ||
|
|
||
| ### Tech Stack <a name="tech-stack"></a> | ||
|
|
||
| > Describe the tech stack and include only the relevant sections that apply to your project. | ||
|
|
||
| <details> | ||
| <summary>Client</summary> | ||
| <ul> | ||
| <li><a href="https://reactjs.org/">React.js</a></li> | ||
| </ul> | ||
| </details> | ||
|
|
||
| <details> | ||
| <summary>Server</summary> | ||
| <ul> | ||
| <li><a href="https://expressjs.com/">Express.js</a></li> | ||
| </ul> | ||
| </details> | ||
|
|
||
| <details> | ||
| <summary>Database</summary> | ||
| <ul> | ||
| <li><a href="https://www.postgresql.org/">PostgreSQL</a></li> | ||
| </ul> | ||
| </details> | ||
|
|
||
| <!-- Features --> | ||
|
|
||
| ### Key Features <a name="key-features"></a> | ||
|
|
||
| > Describe between 1-3 key features of the application. | ||
|
|
||
| - **[key_feature_1]** | ||
| - **[key_feature_2]** | ||
| - **[key_feature_3]** | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> | ||
|
|
||
| <!-- LIVE DEMO --> | ||
|
|
||
| ## 🚀 Live Demo <a name="live-demo"></a> | ||
|
|
||
| > Add a link to your deployed project. | ||
|
|
||
| - [Live Demo Link](https://yourdeployedapplicationlink.com) | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> | ||
|
|
||
| <!-- GETTING STARTED --> | ||
|
|
||
| ## 💻 Getting Started <a name="getting-started"></a> | ||
|
|
||
| > Describe how a new developer could make use of your project. | ||
|
|
||
| To get a local copy up and running, follow these steps. | ||
|
|
||
| ### Prerequisites | ||
|
|
||
| In order to run this project you need: | ||
|
|
||
| <!-- | ||
| Example command: | ||
|
|
||
| ```sh | ||
| gem install rails | ||
| ``` | ||
| --> | ||
|
|
||
| ### Setup | ||
|
|
||
| Clone this repository to your desired folder: | ||
|
|
||
| <!-- | ||
| Example commands: | ||
|
|
||
| ```sh | ||
| cd my-folder | ||
| git clone git@github.com:myaccount/my-project.git | ||
| ``` | ||
| ---> | ||
|
|
||
| ### Install | ||
|
|
||
| Install this project with: | ||
|
|
||
| <!-- | ||
| Example command: | ||
|
|
||
| ```sh | ||
| cd my-project | ||
| gem install | ||
| ``` | ||
| ---> | ||
|
|
||
| ### Usage | ||
|
|
||
| To run the project, execute the following command: | ||
|
|
||
| <!-- | ||
| Example command: | ||
|
|
||
| ```sh | ||
| rails server | ||
| ``` | ||
| ---> | ||
|
|
||
| ### Run tests | ||
|
|
||
| To run tests, run the following command: | ||
|
|
||
| <!-- | ||
| Example command: | ||
|
|
||
| ```sh | ||
| bin/rails test test/models/article_test.rb | ||
| ``` | ||
| ---> | ||
|
|
||
| ### Deployment | ||
|
|
||
| You can deploy this project using: | ||
|
|
||
| <!-- | ||
| Example: | ||
|
|
||
| ```sh | ||
|
|
||
| ``` | ||
| --> | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> | ||
|
|
||
| <!-- AUTHORS --> | ||
|
|
||
| ## 👥 Authors <a name="authors"></a> | ||
|
|
||
| > Mention all of the collaborators of this project. | ||
|
|
||
| 👤 **Author1** | ||
|
|
||
| - GitHub: [@githubhandle](https://github.com/githubhandle) | ||
| - Twitter: [@twitterhandle](https://twitter.com/twitterhandle) | ||
| - LinkedIn: [LinkedIn](https://linkedin.com/in/linkedinhandle) | ||
|
|
||
| 👤 **Author2** | ||
|
|
||
| - GitHub: [@githubhandle](https://github.com/githubhandle) | ||
| - Twitter: [@twitterhandle](https://twitter.com/twitterhandle) | ||
| - LinkedIn: [LinkedIn](https://linkedin.com/in/linkedinhandle) |
There was a problem hiding this comment.
- You used the correct template from Microverse for your README file, but currently, it is not well designed for this project. Please customize the sections and make sure they make sense for this project and look professional. Like the 'Author' section, it should contain links to your specific social pages.
ABDULALI3468
left a comment
ABDULALI3468
left a comment
There was a problem hiding this comment.
Changes Required 👍
Hi @abel-tefera ,
Great work on making the changes requested by a previous reviewer 👏
You've done really well implementing some of the requested changes, but there are still some which aren't been addressed yet.
Highlights
✅All linters are checked.
✅Project is professionally documented.
✅The right GitHub flow method has been used.
✅Professional pull request title and description.
Required Changes ♻️
Check the comments below to have a look at the required changes.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification.
- This is My GitHub:
- This is My Linkedin:
- This is My Twitter:
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <a name="readme-top"></a> | ||
|
|
||
| <div align="center"> | ||
|
|
||
| <h3><b>Hello Microverse Project</b></h3> | ||
|
|
||
| </div> | ||
|
|
||
| <!-- TABLE OF CONTENTS --> | ||
|
|
||
| # 📗 Table of Contents | ||
|
|
||
| - [📖 About the Project](#about-project) | ||
| - [🛠 Built With](#built-with) | ||
| - [Tech Stack](#tech-stack) | ||
| - [Key Features](#key-features) | ||
| <!-- - [🚀 Live Demo](#live-demo) --> | ||
| - [💻 Getting Started](#getting-started) | ||
| - [Setup](#setup) | ||
| - [Prerequisites](#prerequisites) | ||
| <!-- - [Install](#install) --> | ||
| <!-- - [Usage](#usage) --> | ||
| <!-- - [Run tests](#run-tests) --> | ||
| <!-- - [Deployment](#triangular_flag_on_post-deployment) --> | ||
| - [👥 Authors](#authors) | ||
| <!-- - [🔭 Future Features](#future-features) --> | ||
| - [🤝 Contributing](#contributing) | ||
| - [⭐️ Show your support](#support) | ||
| - [🙏 Acknowledgements](#acknowledgements) | ||
| - [📝 License](#license) | ||
|
|
||
| <!-- PROJECT DESCRIPTION --> | ||
|
|
||
| # 📖 Hello Microverse Project <a name="about-project"></a> | ||
|
|
||
| > A simple HTML/CSS project. | ||
|
|
||
| **Hello Microverse Project** is my first project as a Microverse student. | ||
|
|
||
| ## 🛠 Built With <a name="built-with"></a> | ||
|
|
||
| ### Tech Stack <a name="tech-stack"></a> | ||
|
|
||
| > The technologies used are HTML/CSS only. | ||
|
|
||
| <details> | ||
| <summary>Client</summary> | ||
| <ul> | ||
| <li><a href="https://reactjs.org/">HTML/CSS</a></li> | ||
| </ul> | ||
| </details> | ||
|
|
||
| ### Key Features <a name="key-features"></a> | ||
|
|
||
| > Key features include: | ||
|
|
||
| - **Hello Microverse Header** | ||
| - **Green text color** | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> | ||
|
|
||
| <!-- GETTING STARTED --> | ||
|
|
||
| ## 💻 Getting Started <a name="getting-started"></a> | ||
|
|
||
| > Steps to run: | ||
|
|
||
| To get a local copy up and running, follow these steps. | ||
|
|
||
| ### Prerequisites | ||
|
|
||
| In order to run this project you need: | ||
|
|
||
| - A browser | ||
|
|
||
| ### Setup | ||
|
|
||
| Clone this repository to your desired folder: | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> | ||
|
|
||
| <!-- AUTHORS --> | ||
|
|
||
| ## 👥 Authors <a name="authors"></a> | ||
|
|
||
| 👤 **Author1** | ||
|
|
||
| - GitHub: [@abel-tefera](https://github.com/abel-tefera) | ||
| - Twitter: [@twitterhandle](https://twitter.com/abelteferabelay) | ||
| - LinkedIn: [LinkedIn](https://linkedin.com/in/abel-tefera-b1b625153) | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> | ||
|
|
||
| ## 🤝 Contributing <a name="contributing"></a> | ||
|
|
||
| Contributions, issues, and feature requests are welcome! | ||
|
|
||
| Feel free to check the [issues page](../../issues/). | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> | ||
|
|
||
| <!-- SUPPORT --> | ||
|
|
||
| ## ⭐️ Show your support <a name="support"></a> | ||
|
|
||
| > Write a message to encourage readers to support your project | ||
|
|
||
| If you like this project, please star it. | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> | ||
|
|
||
| <!-- ACKNOWLEDGEMENTS --> | ||
|
|
||
| ## 🙏 Acknowledgments <a name="acknowledgements"></a> | ||
|
|
||
| > Give credit to everyone who inspired your codebase. | ||
|
|
||
| I would like to thank the Microverse community for giving me the opportunity to work on the cirriculum. | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> | ||
|
|
There was a problem hiding this comment.
In the case of README consider not leaving any of the sections in the Microverse README template as it's a project requirement.
- The only optional section is FAQ.
- Make sure the to add section Future Features, including 1-3 potential features to be added.
README.md
Outdated
|
|
||
| ## 📝 License <a name="license"></a> | ||
|
|
||
| This project is [MIT](./LICENSE) licensed. |
There was a problem hiding this comment.
Your README link to your MIT LICENSE file is not working and showing a 404 ERROR as there is no LICENSE file in your repo. Consider adding one.
HOW TO ADD LICENSE:-
Check the following Link to understand how to add LICENSE to your GitHub repo.
abel-tefera
force-pushed
the
initialize-project
branch
from
7a87bcf to
b5aad6c
Compare
AlphaNtihinduka
left a comment
AlphaNtihinduka
left a comment
There was a problem hiding this comment.
STATUS: APPROVED 🟢 👏
Hi @abel-tefera 🙋♂️,
Your project is complete! There is nothing else to say other than... Great job 👏
Congratulations! 🎉
TO HIGHLIGHT:
- Your project is professional ✔️
- Your repo is professional ✔️
- Well-structured files ✔️
- Professional README.md file 💯
- No linter errors ✔️
Now you can merge this branch and move on 🥇
Optional suggestions
- Kindly refer to the inline optional suggestions made. Ensure to apply them to have a professional project that suits recruiters' needs.
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
HAPPY CODING AND GOOD LUCK WITH THE COMING ONES 🤞 🍀
4 participants
Summary