Add comprehensive test coverage for event handling and filtering#6
Merged
abedurftig merged 3 commits intomainfrom Jan 19, 2026
Merged
Conversation
- Add ApplicationInteractorTest (12 tests) for all event handlers - Add deleteDocument tests to ArchiveServiceImplTest (9 tests) - Add ApplicationModel filtering and selection tests (14 tests) - Add path separator tests to FilesServiceImplTest (3 tests) This brings total test count from 51 to ~89 tests, improving coverage of critical event handling, document lifecycle operations, and platform-specific path handling. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Introduced FxScheduler abstraction to decouple ApplicationInteractor from Platform.runLater(). Tests now use direct execution instead of requiring a functional JavaFX Application Thread, which hangs indefinitely in headless CI environments like GitHub Actions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This brings total test count from ~51 to ~89 tests, improving coverage of:
Test plan
🤖 Generated with Claude Code