Skip to content

Fix Maven compiler plugin source/target version mismatch #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abedurftig merged 1 commit into from
Jan 16, 2026
Merged

Fix Maven compiler plugin source/target version mismatch #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .beads/issues.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
{"id":"smartfiles-tre","title":"DateTimeFormatter duplicated across classes","description":"DateTimeFormatter.ofPattern(\"MMM d, yyyy 'at' HH:mm\") is defined identically in both:\n- ApplicationInteractor.java (line 11)\n- AppConfiguration.java (line 13)\n\nThis should be centralized to avoid inconsistency if the format needs to change.\n\n**Fix:** Create a single shared constant or utility class for date formatting.","status":"open","priority":3,"issue_type":"task","created_at":"2026-01-15T22:36:46.434919+01:00","created_by":"abedurftig","updated_at":"2026-01-15T22:36:46.434919+01:00"}
{"id":"smartfiles-u4i","title":"Apply consistent tag styling between filter and document views","status":"closed","priority":2,"issue_type":"task","created_at":"2026-01-11T21:49:21.617484+01:00","created_by":"abedurftig","updated_at":"2026-01-11T21:53:15.289719+01:00","closed_at":"2026-01-11T21:53:15.289719+01:00","close_reason":"Closed"}
{"id":"smartfiles-vap","title":"Missing Platform.runLater in ApplicationInteractor event handlers","description":"In ApplicationInteractor.java, most event handlers correctly use Platform.runLater() to update the model on the JavaFX Application Thread. However, two handlers do not:\n\n- handleDocumentTagAddedEvent (line 49-51) calls model.updateDocumentTags() directly\n- handleArchiveEntryAddedEvent (line 61-64) calls model.addDocumentFromArchiveEntry() directly\n\nSince Spring events can be published from any thread, these could cause UI updates from non-FX threads, leading to race conditions or crashes.\n\n**Fix:** Wrap these calls in Platform.runLater().","status":"closed","priority":1,"issue_type":"bug","created_at":"2026-01-15T22:32:45.051937+01:00","created_by":"abedurftig","updated_at":"2026-01-16T20:58:09.470451+01:00","closed_at":"2026-01-16T20:58:09.470451+01:00","close_reason":"Closed"}
{"id":"smartfiles-w73","title":"Maven compiler plugin source/target mismatch","description":"In pom.xml, the properties define java.version=25 and maven.compiler.source/target=25, but the maven-compiler-plugin configuration explicitly sets source=22 and target=22 (lines 129-130), contradicting the properties.\n\n**Fix:** Remove explicit source/target from plugin config to use the property values, or update to match.","status":"open","priority":2,"issue_type":"bug","created_at":"2026-01-15T22:36:17.931659+01:00","created_by":"abedurftig","updated_at":"2026-01-15T22:36:17.931659+01:00"}
{"id":"smartfiles-w73","title":"Maven compiler plugin source/target mismatch","description":"In pom.xml, the properties define java.version=25 and maven.compiler.source/target=25, but the maven-compiler-plugin configuration explicitly sets source=22 and target=22 (lines 129-130), contradicting the properties.\n\n**Fix:** Remove explicit source/target from plugin config to use the property values, or update to match.","status":"in_progress","priority":2,"issue_type":"bug","created_at":"2026-01-15T22:36:17.931659+01:00","created_by":"abedurftig","updated_at":"2026-01-16T21:15:43.867189+01:00"}
{"id":"smartfiles-we7","title":"Display document details dateLastModified and dateCreated in the document details","description":"Display the dateCreated and dateLastModified of the selected document in the document details in the bottom right.","status":"open","priority":2,"issue_type":"feature","created_at":"2026-01-07T21:31:02.161058+01:00","created_by":"abedurftig","updated_at":"2026-01-07T21:32:30.284216+01:00"}
{"id":"smartfiles-wyr","title":"Window size and position not persisted","description":"The application starts with fixed dimensions (1024x768) and does not save/restore window size or position. This is a user experience issue as preferences are lost on restart.\n\n**File:** SmartFilesApp.java (lines 22-23)\n\n**Fix:** Save window bounds to settings on close, restore on startup.","status":"open","priority":4,"issue_type":"feature","created_at":"2026-01-15T22:37:37.871391+01:00","created_by":"abedurftig","updated_at":"2026-01-15T22:37:37.871391+01:00"}
{"id":"smartfiles-yes","title":"Theme change event handler inconsistent with threading pattern","description":"handleLightThemeActivatedSettingsChangedEvent (lines 57-59) modifies the model directly without Platform.runLater(). While the theme toggle is likely called from the UI thread, the pattern should be consistent for safety.\n\n**Fix:** Wrap in Platform.runLater() for consistency with other handlers.","status":"closed","priority":3,"issue_type":"task","created_at":"2026-01-15T22:36:52.962703+01:00","created_by":"abedurftig","updated_at":"2026-01-16T20:58:09.473652+01:00","closed_at":"2026-01-16T20:58:09.473652+01:00","close_reason":"Closed"}
Expand Down
2 changes: 0 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,6 @@
<version>${lombok.version}</version>
</path>
</annotationProcessorPaths>
<source>22</source>
<target>22</target>
</configuration>
</plugin>
</plugins>
Expand Down