fix: Make genome assembly optional. Use builtin chromsizes by default#20
Merged
thomas-reimonn merged 3 commits intomainfrom Dec 29, 2025
Merged
fix: Make genome assembly optional. Use builtin chromsizes by default#20thomas-reimonn merged 3 commits intomainfrom
thomas-reimonn merged 3 commits intomainfrom
Conversation
Contributor
|
Thank you for doing this! It looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to specify an assembly at all, unless the name is useful for cross-referencing to orthogonal datasets.
This PR makes
--assemblycompletely optional and uses the built-in chromsizes of the first input contact map as the default reference chromosome sizes for the run.