Addressing greptile's issues#4
Merged
abdelsfane merged 4 commits intoabdelsfane:fix/config-redaction-schema-drivenfrom Feb 8, 2026
Merged
Addressing greptile's issues#4abdelsfane merged 4 commits intoabdelsfane:fix/config-redaction-schema-drivenfrom
abdelsfane merged 4 commits intoabdelsfane:fix/config-redaction-schema-drivenfrom
Conversation
Doesn't matter what it is, it's a sentinel and it should get eaten; the orig value is always safe to keep (as long as it exists).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry that I had to completely rewrite your code, but the two wildcard paths (array[].field and record.*.field) were a pain to shoehorn into the existing one, so I gave up and started anew.
BTW: Do we really need the "there's no uihints object given to us" cases? As far as I see, we always get that object, and it is always populated. That's a whole lot of code we could get rid of if we made it mandatory.
I'm a bit exhausted, or I would add more tests to redact. Feel free to add some test cases with records and arrays and nested sh...stuff. I tested one record manually in the UI; it worked perfectly. (agents.defaults.memorySearch.remote.apiKey)
Also, I don't know if the UI code properly looks up records and arrays. The one I tested was rendered as a password field, but I'm not sure if the keyname lookup is still there or not. As I said, exhausted mentally.