Skip to content

Change byline element from <p> to <div>#98

Merged
drzax merged 2 commits intomainfrom
bugfix/header-byline
Feb 20, 2026
Merged

Change byline element from <p> to <div>#98
drzax merged 2 commits intomainfrom
bugfix/header-byline

Conversation

@phocks
Copy link
Member

@phocks phocks commented Feb 6, 2026

Have done a bit of testing. This doesn't appear to affect styling/layout.

Fixes #97

@phocks phocks requested review from AshKyd and drzax February 6, 2026 00:10
Copy link
Member

@AshKyd AshKyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice.

* main:
  Update workflow to commit snapshots to the right place
  Update snapshots
  Much improved e2e tests - less flakey - more of them
  More visual tests
  Update how tests are run locally by default
  Update workflow dependency versions
  Update license dates
  Update visual spec snapshots
Copy link
Member

@drzax drzax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Also I merged in the changes from main to make the e2e tests run again as this was a useful test case for them. It passed!

@drzax drzax merged commit 3890b3c into main Feb 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block elements in <p> tags not valid HTML (and Odyssey puts <ul> tags inside <p> tags)

3 participants