Transfer data-scheme attributes to color-scheme css props#92
Merged
Conversation
Playwright visual snapshot differences were detected.View the Playwright report to review the visual differences. |
Member
Author
|
/approve-snapshots |
|
Updating snapshots. Click here to see the status. |
|
📸 Successfully updated and committed Playwright snapshots! |
Playwright visual snapshot differences were detected.View the Playwright report to review the visual differences. |
drzax
force-pushed
the
better-colour-scheme-support
branch
from
d8fd653 to
8b322cc
Compare
AshKyd
approved these changes
Jan 22, 2026
Member
AshKyd
left a comment
AshKyd
left a comment
There was a problem hiding this comment.
Hm. Yeah I think we'd need this for the iframe transparency to work anyway. Good call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've supported Presentation Layer's custom colour scheme attributes in Odyssey for some time, but these should also be expressed as CSS color-scheme properties to ensure descendent elements understand their environment.
This will let us, for example, rely on web-standard colour scheme support mechanics for iframe embeds which have colour scheme support defined.