Rust bindings with documentations on docs.rs/april_asr#16
Open
cdxker wants to merge 15 commits intoabb128:mainfrom
Open
Rust bindings with documentations on docs.rs/april_asr#16cdxker wants to merge 15 commits intoabb128:mainfrom
cdxker wants to merge 15 commits intoabb128:mainfrom
Conversation
|
abb128
requested changes
Jul 7, 2023
Owner
abb128
left a comment
abb128
left a comment
There was a problem hiding this comment.
Bindings look good! I'm a bit concerned about the build script downloading binaries though
| path::{Path, PathBuf}, | ||
| }; | ||
|
|
||
| const APRIL_RELEASE_URL: &str = "http://github.com/arguflow/april-asr/releases/download/v-0.0.1/libaprilasr.so"; |
Owner
There was a problem hiding this comment.
Is it necessary to download a binary? I'd rather it just use the local built .so
Author
There was a problem hiding this comment.
I could add it as a feature flag, I was having issues linking the 2 .so files. I copied this pattern from how libonxruntime was doing their bindings. https://github.com/microsoft/onnxruntime/blob/main/rust/onnxruntime-sys/build.rs#L19.
| }; | ||
|
|
||
| const APRIL_RELEASE_URL: &str = "http://github.com/arguflow/april-asr/releases/download/v-0.0.1/libaprilasr.so"; | ||
| const ONNX_RELEASE_URL: &str = "http://github.com/microsoft/onnxruntime/releases/download/v1.13.1/onnxruntime-linux-x64-1.13.1.tgz"; |
Owner
There was a problem hiding this comment.
Same here, I'd rather it use the version in lib/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.