Fix Task.__call__ to require config as positional argument #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Task.__call__ method signature from accepting config as an optional keyword argument to requiring it as a
positional parameter. This makes the config parameter mandatory and more explicit, improving the API design and
preventing potential issues from missing config.
- Change signature from __call__(self, **kwargs) to __call__(self, config, **kwargs)
- Replace kwargs.get("config") with direct assignment of config parameter
Minimum allowed line rate is |
1 similar comment
Minimum allowed line rate is |
Minimum allowed line rate is |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the Task.__call__ method signature to require config as a mandatory positional parameter instead of accepting it as an optional keyword argument. This aims to make the config parameter more explicit and prevent issues from missing config values.
Key changes:
- Modified
Task.__call__signature from__call__(self, **kwargs)to__call__(self, config, **kwargs) - Changed config retrieval from
kwargs.get("config")to direct assignment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed Task.call method signature from accepting config as an optional keyword argument to requiring it as a positional parameter. This makes the config parameter mandatory and more explicit, improving the API design and preventing potential issues from missing config.