Enhances Spawn Task to Terminate Process and Children #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed line rate is |
Minimum allowed line rate is |
1 similar comment
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change modifies the
SpawnExecuteTaskto leveragepsutil, if available, to not only terminate the spawn process at the end, but also all the child processes. Ifpsutilis not available, the task resorts to the previous behavior and only kills the spawn process. This may result on dangling process in some instances.One of the reasons for this change is to be able to launch a web application behind a server using
npm. NPM is notorious for leaving child processes behind if they are not explicitly killed. This implementation, providedpsutilis installed, will ensure all processes are terminated.