Conversation
This was a shortcut for writing directly to NetCDF that's been deprecated for almost two years. Since removing it will shift the order of positional arguments, I went ahead and made the arguments keyword-only at the same time. I suspect that's how the vast majority of users were calling it anyways, since the first argument was the deprecated "path".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
pathwas a shortcut for writing directly to NetCDF that's been deprecated for almost two years. Users can call theto_netcdfmethod of the returned object instead.Since
pathwas the first positional argument, removing it will change the order of the remainingto_xarrayarguments, so I'm changing them all to keyword-only at the same time. This will be a breaking change for anyone who was calling the method with positional arguments, but I suspect that this is a rare use case since you would need to explicitly passNoneas the first argument to avoid the deprecation warning.