Skip to content

Move CSS from static file to Python module#58

Merged
aazuspan merged 2 commits intomainfrom
css-module
Feb 19, 2025
Merged

Move CSS from static file to Python module#58
aazuspan merged 2 commits intomainfrom
css-module

Conversation

@aazuspan
Copy link
Copy Markdown
Owner

@aazuspan aazuspan commented Feb 19, 2025

Related issue

This is an indirect fix for #57, which resulted from unspecified encoding when reading the CSS file defaulting to gbk in some locales.

Description

Replace the static CSS file with a CSS constant that we can import. This gives a tiny one-time performance improvement, but more importantly simplifies some code. The downside is no editor support when editing the CSS.

Checklist

  • I have updated the CHANGELOG with any added features, changes, fixes, or removals.

This gives a tiny performance improvement, but more importantly
simplifies some code. The downside is no editor support when
editing the CSS.
@aazuspan aazuspan added the bug Something isn't working label Feb 19, 2025
@aazuspan aazuspan self-assigned this Feb 19, 2025
@aazuspan aazuspan merged commit f26a57c into main Feb 19, 2025
6 checks passed
@aazuspan aazuspan deleted the css-module branch February 19, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant