Change collection type for Route Collections #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h routes regardless of abstractRouteCollection implementation (compiled or not)
Author
|
@aaronlord is there anything I can do to help get this closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the collection type from RouteCollection to AbstractRouteCollection, which is a common ancestor of both RouteCollection and CompiledRouteCollection. Calls getRoutes to retrieve an iterable route collection instead of just passing the RouteCollection object, which enables the same functionality for both collection types.
It looks like the phpunit check for this isn't fully implemented, but I'm able to execute the
laroute:generatecommand with these changes and all of my routes generate successfully.