Feature Request - Show host information on packet diff screen #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanFoster
commented
Jan 15, 2022
|
|
||
| for line in out.split('\n'): | ||
| m = re.match(r'''\s*(\d+).+?SMB2?\s*\d+\s*(.+)''', line) | ||
| ips = re.match(r'''.* (\d+\.\d+\.\d+\.\d+) → (\d+\.\d+\.\d+\.\d+).*''', line) |
Author
There was a problem hiding this comment.
This was just a proof of concept; I believe it might be better to use the xml output of tshark -T pdml -r ../smb.pcapng '!browser && (smb||smb2)' to gather the required fields ip.src_host / ip.dst_host - potentially with alias support in smbcmp itself for matching arbitrary src/dst ips/hostnames to user defined hostnames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smbcmp is great tool for comparing packets between two hosts, but is harder to use when multiple hosts are involved.
This PR acts as an initial feature request/proposal to smbcmp, but isn't production ready 👍
Example
Showing the src/dst fields with human readable/aliased host names: