Skip to content

Improved readability (PEP8 linting + fixing dirty hacks)#3

Open
Sanduuz wants to merge 1 commit intoaapooksman:mainfrom
Sanduuz:improvement/pep8_lint
Open

Improved readability (PEP8 linting + fixing dirty hacks)#3
Sanduuz wants to merge 1 commit intoaapooksman:mainfrom
Sanduuz:improvement/pep8_lint

Conversation

@Sanduuz
Copy link

@Sanduuz Sanduuz commented Aug 24, 2023

No description provided.

@qdii
Copy link

qdii commented Jan 21, 2024

@Sanduuz instead of removing the OSException, could you log it as well? it may give more details about the failure.

@Sanduuz
Copy link
Author

Sanduuz commented Jan 21, 2024

@Sanduuz instead of removing the OSException, could you log it as well? it may give more details about the failure.

Definitely could and there's A LOT of other improvements as well to be done to actually make the codebase maintainable for future :D

But I'm pretty sure that @aapooksman won't merge this either (because "it works, so why break it" ;D) so it would be probably easier to just update my own fork.


description = """

description = r"""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this must be fixing that invalid escape sequence warning seen here https://www.youtube.com/watch?v=3qSxxNvuEtg&t=13m

@aapooksman
Copy link
Owner

aapooksman commented Aug 30, 2024

@Sanduuz I'm happy to merge improvements, but I've not had the time to go through this pull request as it introduces a lot of changes in one commit.

I'll take these into account next time when I'm revamping the code more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants