Update README with TLS session secrets logging#23
Open
wilco375 wants to merge 1 commit intoaapooksman:mainfrom
Open
Update README with TLS session secrets logging#23wilco375 wants to merge 1 commit intoaapooksman:mainfrom
wilco375 wants to merge 1 commit intoaapooksman:mainfrom
Conversation
Added instructions for logging TLS session secrets using SSLKEYLOGFILE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to add support for SSLKEYLOGFILE so that I could create a pcap capture of the traffic, and decrypt this in Wireshark. But as it turns out, since Python 3.8,
ssl.create_default_context, which this application uses, already supports this:I added some documentation to the README explaining the usage of the key log file.
P.S. sorry for the double PR, apparently renaming a branch after creating a PR closes it automatically.