Fix error when there are empty lines in real certificate file#14
Open
imnuke wants to merge 1 commit intoaapooksman:mainfrom
Open
Fix error when there are empty lines in real certificate file#14imnuke wants to merge 1 commit intoaapooksman:mainfrom
imnuke wants to merge 1 commit intoaapooksman:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are empty lines in the fullchail certificate file in real_certs, empty lines are incorrectly interpreted as certificates. This causes
OpenSSL.crypto.load_certificateto throw an error.acme.sh, a widely-used tool for certificate management, produces certificate chains in a format with empty lines separating individual certificates:
This fix modifies the certificate processing to skip empty lines, ensuring that only valid certificates are passed to
OpenSSL.crypto.load_certificate. This change enhances compatibility with acme.sh output and prevents unnecessary errors.