Skip to content

Conversation

@jjpinto
Copy link

@jjpinto jjpinto commented Jan 9, 2026

This PR makes a small cleanup in getNodeOpts. The SNMP enactment driver case was using a raw fmt.Print, which didn’t quite fit with how the rest of the function handles missing or unimplemented options.

I switched it to return a proper error instead.

The idea here is just to make the behavior a bit clearer and more consistent since the previous version printed a TODO message but didn’t actually signal anything to the caller, so the function would silently fall through.

Returning an error feels more idiomatic and makes it obvious that this path isn’t implemented yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant