Open
Conversation
…nly only for ledger entries after the cached timestamp. expire the cache after 1 hour
… if/when redis is unavailable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caches point totals in Redis with a timestamp for when they were calculated. points totaling will use the cached points and the timestamp to load in everything since that timestamp and add the new entries to get the current total. Totals are only cached if the last cache entry has expired so it will update from scratch after the entry expires. Alternatively we could make it update the cache each time totaling is run, I'm interested in what y'all think.
Currently I've got the ttl on these Redis entries set at 1 hour out of an abundance of caution, but maybe it should be way longer, like 1 or 2 days?