Open
Conversation
…he beginning and replace sql for each badge check with php
Contributor
Author
|
@ejk I've tested this locally with all the changed badge types. This is good to review now. I've left the old code commented out for now to make it easier to compare logic, but can remove before rolling it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize badge check by loading all ledger entries for game term at the beginning and replace sql for each badge check with php.
Before badge check would make more queries (and slower) for players who played the least, which are the majority. This reverses that, so now the number of queries are reduced for everyone, but may be a little (variation under 100ms) slower for our biggest players.
@ejk, I will be running through a bunch of badge types while you're out probably not worth reviewing until then.