fixed exception when a non-existant bib record is attempted to be loaded #187
Open
lauriek334 wants to merge 1 commit intomasterfrom
Open
fixed exception when a non-existant bib record is attempted to be loaded #187lauriek334 wants to merge 1 commit intomasterfrom
lauriek334 wants to merge 1 commit intomasterfrom
Conversation
…ib record is not in the catalog. initialized bib_record before the try/catch to avoid confusion, renamed $json variable to $response_object as json_decode method returns a PHP object. Test bib to load: https://aadl.org/catalog/record/ib-100010008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exception being thrown:
PHP message: Uncaught PHP Exception Error: "Attempt to assign property "_id" on null at /var/www/drupal10/web/modules/custom/arborcat/src/Controller/DefaultController.php line 61" while reading response header from upstream, client: 10.0.9.41, server: dev.aadl.org, request: "GET /catalog/record/ibib-100059602 HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php8.1-fpm.sock:", host: "dev.aadl.org"
Passing a non existant bibID causes the exception. You can observe it on dev and production - here:
http://dev.aadl.org/catalog/record/ibib-100059602
http://aadl.org/catalog/record/ibib-100059602
Fix:
initialized bib_record before the try/catch
to avoid confusion, renamed $json variable to $response_object as json_decode method returns a PHP object. Test bib to load: https://aadl.org/catalog/record/ib-100010008
Tested locally and on dev.