Open
Conversation
aVolpe
reviewed
Aug 6, 2020
| v-on:change="changeCurrency" | ||
| class="bx-5" | ||
| label="Moneda" | ||
| single-line></v-select> |
Owner
There was a problem hiding this comment.
Esto no es buena idea!, normalmente los framework js requeiren tener un tag vacio en vez de cerrarlo con '>.
| if (row.branchLatitude) { | ||
| row['gmapsLink'] = `https://www.google.com/maps/search/?api=1&query=${row.branchLatitude},${row.branchLongitude}`; | ||
| else | ||
| row['osmLink'] = `https://www.openstreetmap.org/?mlat=${row.branchLatitude}&mlon=${row.branchLongitude}&zoom=17`; |
Owner
There was a problem hiding this comment.
No hay alguna forma de conseguir un link que funcione para ambos? digo para teléfonos móviles donde clickando nos lleva a gmps, si agregamos ambos links?
Author
There was a problem hiding this comment.
Creo que algo más genérico seria usar el esquema geo, pero creo que escapa al propósito de este cambio, que era reemplazar Google por OSM. Otro problema que habria con el esquema geo, es que por alguna razón parece no soportarse bien en los navegadores de escritorio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diego Ramírez diegocrzt@gmail.com