Add support for multiple maps #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
The config `map` property is now a `maps` property, and each has an id and label. If there is more than one map, it will add a map select component that allows the user to select the map. The zoom and pan settings are now persisted per-map, which hopefully makes it easier to switch back and forth between maps to understand how to get from one room to another. The urls now have the map in them. This means upgrading from an old map will break all the old URLs. However, people don't tend to upgrade old maps, so that's not really a big deal. Besides, the rooms will likely have to be changed as a part of the upgrade anyway.
aJanuary
force-pushed
the
add-multi-layer-maps
branch
from
421fb14 to
c5d1a2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config
mapproperty is now amapsproperty, and each has an id and label. If there is more than one map, it will add a map select component that allows the user to select the map.The zoom and pan settings are now persisted per-map, which hopefully makes it easier to switch back and forth between maps to understand how to get from one room to another.
The urls now have the map in them. This means upgrading from an old map will break all the old URLs. However, people don't tend to upgrade old maps, so that's not really a big deal. Besides, the rooms will likely have to be changed as a part of the upgrade anyway.
Resolves #2