-
Notifications
You must be signed in to change notification settings - Fork 313
Update to specification from 1bd263f5373fdc8fa7c17ec8bdb24088996b6828 #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to specification from 1bd263f5373fdc8fa7c17ec8bdb24088996b6828 #579
Conversation
Summary of ChangesHello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the A2A gRPC and JSON specification to version Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces significant updates to the A2A protobuf definitions and their Python bindings. Key changes include renaming CreateTaskPushNotificationConfig to SetTaskPushNotificationConfig, TaskSubscription to SubscribeToTask, and GetAgentCard to GetExtendedAgentCard across both the protobuf messages and gRPC service methods. A new ListTasks method and corresponding request/response messages have been added to support task listing with filtering and pagination. Many fields across various messages (e.g., Task, TaskStatus, Message, Artifact, PushNotificationConfig, AgentCard, AgentSkill) have been marked as required using google.api.field_behavior annotations. Several fields have been made optional, and tenant fields have been introduced in various request messages and corresponding HTTP rules to support multi-tenancy. Field names like mime_type in FilePart were changed to media_type, and content in Message was renamed to parts, with reference_task_ids added to Message. The __slots__ definitions in the a2a_pb2.pyi type stub file were updated to reflect these structural changes.
Commit: a2aproject/A2A@1bd263f