Open
Conversation
Drive-by fix required for implementing combined search by ID and name in frontend. Random digits no longer return a fake ID search result. Leading zeros in input ID are now trimmed to match OSM API behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8 😁
Now for every user's query the frontend makes up to two API requests, one (always) for usernames and one (only if it's a valid number) for UID. When sending two API calls, both must complete before showing the results. Any found UID is displayed on top of the results in bold. In some cases a UID can be a part of or the entire username, so it's possible for UID to show up in results of both API calls. The frontend protects against that by always removing the queried UID from the username API results, so the only way the UID can show up on the page is from the UID API result.
Drive-by fixes: