Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new functionality for working with Roman numerals, including methods to get the next and previous Roman numeral, and to map arrays between numbers and Roman numerals. It also updates documentation and tests to cover these new features, and bumps the package version to reflect the added capabilities.
New Roman numeral utilities
nextRomanandpreviousRomanfunctions to get the next and previous Roman numeral for a given input, respectively, in bothsrc/index.tsandindex.js. [1] [2]mapfunction to convert arrays of numbers to Roman numerals or vice versa, depending on the specified type, in bothsrc/index.tsandindex.js. [1] [2]Documentation updates
README.mdto document the newnextRoman,previousRoman, andmapfunctions, including usage examples.Testing improvements
nextRoman,previousRoman, andmapin both TypeScript and JavaScript test suites (src/tests/index.test.ts,tests/index.test.js). [1] [2]Package version update
1.2.0to2.0.1inpackage.jsonto reflect the new features.