Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors error handling in the Roman numeral utility functions and adds new mathematical operations. The primary change is replacing error returns with exceptions (using
throw), making error handling more consistent and idiomatic. Additionally, new functions for multiplication, division, finding minimum/maximum, and generating random Roman numerals are introduced.Error handling improvements:
isRoman,fromRoman,toRoman,sum,diff,range) now throw exceptions instead of returningErrorobjects for invalid input, ensuring proper error propagation and simplifying usage. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]New mathematical operations:
multiply,divide,max,min, andrandomfunctions to support additional Roman numeral arithmetic and utility operations. These functions include input validation and throw errors for invalid cases. [1] [2]Documentation updates:
Type and interface consistency:
src/index.ts) have been updated to reflect the new error handling approach, removingErrorfrom return types and enforcing exceptions. [1] [2] [3]Code cleanup:
cli.jsto streamline the command-line interface.