Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a CLI interface for converting between numbers and Roman numerals, improves validation logic for Roman numeral inputs, and updates tests to reflect stricter input requirements. The most important changes are summarized below:
CLI Feature Addition
cli.jsandsrc/cli.ts) that allows users to convert between numbers and Roman numerals from the command line. The CLI is registered as thetoromancommand inpackage.json. [1] [2] [3]Input Validation Improvements
isRomanfunction in both JavaScript and TypeScript to reject inputs that are numbers or numeric strings, ensuring only valid Roman numeral strings are accepted. [1] [2]Test Enhancements
isRomanthrows an error when passed a number or a numeric string, ensuring stricter input validation. [1] [2]