Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and improves the Roman numeral utility functions in both the JavaScript (
index.js) and TypeScript (src/index.ts) files. The most significant changes include simplifying the logic for validating and converting Roman numerals and improving error handling and documentation.Functionality and logic improvements:
toRomanfunction to use a mapping approach for converting numbers to Roman numerals, replacing the previous verbose logic with a more concise and maintainable loop. This also changes error handling from returningErrorobjects to throwing exceptions for invalid input. [1] [2]isRomanfunction by replacing the use offorEachwith a standardforloop for checking the maximum allowed occurrences of Roman numeral characters, making the logic clearer and ensuring early exit on invalid input. [1] [2]Documentation and type improvements:
getCountfunction in both files, improving code readability and developer experience. [1] [2]