Fix requirements #18
Open
Fix requirements #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Why did you remove torch? Without installing torch after run: python persam.py you get an error: ModuleNotFoundError: No module named 'torch' |
|
The environment can be conda-based or pip-based and removing pytorch out to allow users to choose how they want to install it - either with conda or pip should be the way they do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZrrSkywalker Hi! I fix requitements.txt file, because when you want to install the os and warnings packages with pip, there are errors. Os and warnings do not require additional installation. Additionally, I added pytorch and torchvision libraries.
I have also added to the readme instructions on how to create an environment in a virtual environment