Skip to content

revert ed25519 changes not used #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chcmedeiros merged 1 commit into from
Apr 1, 2025
Merged

revert ed25519 changes not used #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions bolos-mock/src/crypto/ecfp256.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,7 @@ impl<const B: usize> SecretKey<B> {
rand_chacha7::ChaCha8Rng::from_seed(seed)
}

pub fn new(
_: Mode,
curve: Curve,
path: BIP32Path<B>,
ed25519_secret_key_bytes: Option<[u8; 32]>,
) -> Self {
pub fn new(_: Mode, curve: Curve, path: BIP32Path<B>) -> Self {
let bytes = match curve {
Curve::Secp256K1 => {
let secret = k256::ecdsa::SigningKey::random(&mut Self::rng8(path));
Expand All @@ -132,17 +127,13 @@ impl<const B: usize> SecretKey<B> {
*secret.to_bytes().as_ref()
}
Curve::Ed25519 => {
if let Some(bytes) = ed25519_secret_key_bytes {
let secret = ed25519_dalek::SigningKey::from_bytes(&bytes);
secret.to_bytes()
} else {
// Generate random bytes using the path if no bytes provided
let mut bytes = [0u8; 32];
let mut rng = Self::rng8(path);
use rand_chacha8::rand_core::RngCore;
rng.fill_bytes(&mut bytes);
bytes
}
use rand_chacha7::rand_core::RngCore;
let mut rng = Self::rng7(path);
let mut bytes = [0u8; 32];
rng.fill_bytes(&mut bytes);
let secret = ed25519_dalek::SigningKey::from_bytes(&bytes);

secret.to_bytes()
}
Curve::Stark256 => {
panic!("invalid curve passed to ecfp256 new")
Expand Down
Loading