Support unlisted vimeo urls with url parameters#117
Open
JannikApm wants to merge 1 commit intoZod-:masterfrom
Open
Support unlisted vimeo urls with url parameters#117JannikApm wants to merge 1 commit intoZod-:masterfrom
JannikApm wants to merge 1 commit intoZod-:masterfrom
Conversation
JannikApm
force-pushed
the
jp/unlisted-vimeo-links
branch
3 times, most recently
from
4206212 to
f7c5f76
Compare
JannikApm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/Zod-/jsVideoUrlParser/issues/116.
The pattern to extract the hash from the URL did work for URLs with following URL-params. It would ignore the hash completely in this case. I adjusted the regex to allow URL parameters after the hash.