Skip to content

Conversation

@ZigyTheBird
Copy link
Owner

This is meant for #87
I feel like just using JOML is just so much cleaner and more efficient than having our own shit
Other mods/projects using PAL that also use JOML will have a much easier time integrating things with our mod, and also adding new features in the future will be easier due to a lot of math stuff being already available

Copy link
Collaborator

@dima-dencep dima-dencep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can com.zigythebird.playeranimcore.math.Vec3f also be deleted?

@dima-dencep
Copy link
Collaborator

joml is a fairly compact library
image

@ZigyTheBird
Copy link
Owner Author

The special thing about Vec3f is that it's immutable
Not sure if JOML has immutable vectors

@dima-dencep
Copy link
Collaborator

rebase to master please

@dima-dencep
Copy link
Collaborator

The special thing about Vec3f is that it's immutable Not sure if JOML has immutable vectors

it can implement Vector3fc then

@dima-dencep dima-dencep marked this pull request as draft January 2, 2026 11:22
@ZigyTheBird
Copy link
Owner Author

The special thing about Vec3f is that it's immutable Not sure if JOML has immutable vectors

it can implement Vector3fc then

Good idea!

@ZigyTheBird
Copy link
Owner Author

rebase to master please

The reason why I did it like this is because it might conflict with the more parents PR, but if you insist I will

@dima-dencep
Copy link
Collaborator

rebase to master please

The reason why I did it like this is because it might conflict with the more parents PR, but if you insist I will

then finish #87 before this and there will be no conflicts

@ZigyTheBird
Copy link
Owner Author

ZigyTheBird commented Jan 2, 2026

The special thing about Vec3f is that it's immutable Not sure if JOML has immutable vectors

it can implement Vector3fc then

Good idea!

image

Uhh this is a lot of stuff to implement

@dima-dencep
Copy link
Collaborator

Just throw unimplemented exception

@dima-dencep
Copy link
Collaborator

throw new UnsupportedOperationException();

@ZigyTheBird
Copy link
Owner Author

Then what's the point of making it implement Vector3fc

@dima-dencep
Copy link
Collaborator

You no longer have to do something like new Vector3f(vec.x(), vec.y(), vec.z())

@dima-dencep
Copy link
Collaborator

If you don't think it's necessary to implement this, don't do it. I just suggested it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants