-
Notifications
You must be signed in to change notification settings - Fork 3
Use JOMl again #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: more_parents
Are you sure you want to change the base?
Use JOMl again #88
Conversation
dima-dencep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can com.zigythebird.playeranimcore.math.Vec3f also be deleted?
|
The special thing about Vec3f is that it's immutable |
|
rebase to master please |
it can implement |
Good idea! |
The reason why I did it like this is because it might conflict with the more parents PR, but if you insist I will |
then finish #87 before this and there will be no conflicts |
|
Just throw unimplemented exception |
|
throw new UnsupportedOperationException(); |
|
Then what's the point of making it implement Vector3fc |
|
You no longer have to do something like |
|
If you don't think it's necessary to implement this, don't do it. I just suggested it |

This is meant for #87
I feel like just using JOML is just so much cleaner and more efficient than having our own shit
Other mods/projects using PAL that also use JOML will have a much easier time integrating things with our mod, and also adding new features in the future will be easier due to a lot of math stuff being already available