fix: support non-receiver lifetimes in trait functions#122
Merged
p-avital merged 1 commit intoZettaScaleLabs:mainfrom Feb 23, 2026
Merged
fix: support non-receiver lifetimes in trait functions#122p-avital merged 1 commit intoZettaScaleLabs:mainfrom
p-avital merged 1 commit intoZettaScaleLabs:mainfrom
Conversation
742355e to
1dfe346
Compare
p-avital
approved these changes
Feb 23, 2026
Collaborator
p-avital
left a comment
There was a problem hiding this comment.
That looks lovely, thanks for fixing that oversight! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a trait function has lifetimes other than the receiver, codegen would botch the signature.
either of the following wouldn't work:
this PR fixes the problem by: