fix: multi-part services names being mangled incorrectly#66
Open
Carter12s wants to merge 1 commit intoZettaScaleLabs:mainfrom
Open
fix: multi-part services names being mangled incorrectly#66Carter12s wants to merge 1 commit intoZettaScaleLabs:mainfrom
Carter12s wants to merge 1 commit intoZettaScaleLabs:mainfrom
Conversation
Contributor
|
I can confirm that this works - with the change, I can subscribe to a ROS2 Jazzy instance with rmw_zenoh_cpp. The same issue happens with topic names, not just service names. On the ROS side, we are publishing I dumped all zenoh keys: As you can see, the publishers are not encoding the slashes. |
0x53A
added a commit
to 0x53A/ros-z
that referenced
this pull request
Jan 27, 2026
…an switch back to the main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is an appropriate fix for #65 , but I'm not certain.