Open
Conversation
Zenoo
requested changes
Dec 19, 2025
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
YouriDK
force-pushed
the
901---Clan-roles-(with-editable-name/permissions)
branch
from
b411df7 to
803dfbd
Compare
Zenoo
requested changes
Dec 22, 2025
server/prisma/migrations/20251221235728_move_clan_permissions/migration.sql
Show resolved
Hide resolved
Co-authored-by: Franck <perso@franckdemoute.fr>
Zenoo
reviewed
Feb 22, 2026
| const role = await prisma.clanRole.create({ | ||
| data: { | ||
| clanId: id, | ||
| name, |
Owner
There was a problem hiding this comment.
Name should be checked for length, since it's limited to 50 in the schema
| const role = await prisma.clanRole.update({ | ||
| where: { id: roleId }, | ||
| data: { | ||
| name: req.body.name, |
Owner
There was a problem hiding this comment.
Same here, should be checked for length
Comment on lines
+2112
to
+2114
| await prisma.clanRole.delete({ | ||
| where: { id: roleId }, | ||
| }); |
Owner
There was a problem hiding this comment.
What happens if we delete the Member role you attributed by default?
To be honest, I'm not sure why we have this member role, since it's not created on clan creation either, just in the single migration file.
Owner
There was a problem hiding this comment.
I remember telling you about this default role, but since it can be deleted and is not created by default when we create a clan, I don't see a use for having it, we might as well remove it.
Contributor
Author
There was a problem hiding this comment.
I'll remove this migration then :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of Clan roles a lil a bit late xD