This repository was archived by the owner on Jul 6, 2025. It is now read-only.
refactoring capturing method #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
PaymentControllerandMobilePayServiceclasses to improve the handling of payment captures by usingorderIdinstead ofpaymentId. Additionally, there are minor refactoring and logging improvements.Changes to Payment Handling:
src/main/java/com/zenfulcode/commercify/commercify/controller/PaymentController.java: Modified thecapturePaymentmethod to useorderIdinstead ofpaymentId.src/main/java/com/zenfulcode/commercify/commercify/integration/mobilepay/MobilePayService.java: Updated thecapturePaymentmethod to find payments byorderIdand added logging for capturing payments. [1] [2]Refactoring:
src/main/java/com/zenfulcode/commercify/commercify/integration/mobilepay/MobilePayService.java: Removed the unused import forPriceRequest.Logging Improvements:
src/main/java/com/zenfulcode/commercify/commercify/integration/mobilepay/MobilePayService.java: Added logging to capture payment details includingorderIdand formatted amount.Method Signature Update:
src/main/java/com/zenfulcode/commercify/commercify/integration/mobilepay/MobilePayService.java: Changed thecapturePaymentmethod signature to acceptcaptureAmountas a long and addedcurrencyparameter.