-
Notifications
You must be signed in to change notification settings - Fork 2
Autosplitter #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
1nf3rna
wants to merge
42
commits into
ZellyDev-Games:main
Choose a base branch
from
1nf3rna:autosplitter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Autosplitter #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to do: file format for splitter language, add usage to main project, test functionality
Currently only supports NWA
- moved public stuff to top of file and private stuff to bottom - added comments
- moved public stuff to the top of the file and private to the bottom - changed NWASplitter stuct to make it generic - added compare_type enum (might remove this) - added Element and MemoryEntry structs to make generic interface - added setup function for initializing memory and conditions - made client public - updated Update function for generic interface, construct arguments, build multi-byte values from little endian data - start, reset, and split helper functions updated for generic usability - addedfindInSlice, compareTypeConverter, and compare functions for generic usability
- added example usage
added autosplitter service initialization and activation
added service struct added service thread to connect, setup NWA splitter, control splitter
added read deadline
removed unneeded enum and converter function made MemoryEntry struct variables public fixed hex to int conversion and byte to int conversion added output for invalid condition lengths
…d QUSB, added start condition object, updated autosplit format, added temporary splitcount and run state tracking, QUSB implementation
…te import function for new format, added start conditions to import/update/output, added soft and hard console reset options, rewrote update function for improved performance, rewrote/replaced findInSlice function, added hex to int converter
…esQuery object, disabled unused functions
Author
|
Also need to prevent crashing if the EMU is paused ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for NWA and QUSB autosplitters
Checklist
task fmt)task test)task lint)Notes for reviewers
TODO:
main.go
autosplitters/service.go
autosplitters/QUSB2SNES/qusb2snes_splitter.go