feat: Removed the hardcoded HTTP scheme and port to allow the user to… #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… decide what they want to use. Currently, HTTPS URIs are changed to HTTP, which can prevent communication with the printer.
|
It appears that this repository is currently no longer actively maintained. However, the requested fix (along with several other improvements) is now available in an actively maintained fork: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the hardcoded HTTP scheme and port to allow the user to decide what they want to use. Currently, HTTPS URIs are changed to HTTP, which can prevent communication with the printer.
Recently experienced this on a Windows Print Server where SSL was required. Took a while to work out why the request was failing, but eventually found the scheme hardcoded in the library. Removing it allowed me to specify HTTPS in the server's address.