Skip to content

Comments

Apply iOS style to all buttons#29

Open
manupawickramasinghe wants to merge 1 commit intomainfrom
ios-button-style-10014785844147480555
Open

Apply iOS style to all buttons#29
manupawickramasinghe wants to merge 1 commit intomainfrom
ios-button-style-10014785844147480555

Conversation

@manupawickramasinghe
Copy link
Member

This change updates the application's button style to mimic the iOS design language. A new drawable resource btn_ios_background.xml was created to define the button's shape (rounded corners) and color (blue, with a darker shade for the pressed state). A new style Widget.Button.iOS was defined in styles.xml referencing this background and setting the text color to white. This style is applied globally via the buttonStyle attribute in the AppTheme, ensuring all buttons in the application adopt the new look. Additionally, fragment_camera.xml was cleaned up by removing duplicate attributes (android:labelFor and android:importantForAccessibility) that were causing build failures.


PR created automatically by Jules for task 10014785844147480555 started by @manupawickramasinghe

- Create `btn_ios_background.xml` drawable with rounded corners and blue color selector.
- Add `Widget.Button.iOS` style in `styles.xml`.
- Apply `Widget.Button.iOS` globally via `buttonStyle` in `AppTheme`.
- Remove explicit style from `buttonKill` in `fragment_camera.xml`.
- Fix duplicate attributes in `fragment_camera.xml` to fix build.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant