Skip to content

Comments

🎨 Palette: Add copy icon to IP address and fix XML duplicates#28

Open
manupawickramasinghe wants to merge 1 commit intomainfrom
palette-ux-improvement-11727913379180764890
Open

🎨 Palette: Add copy icon to IP address and fix XML duplicates#28
manupawickramasinghe wants to merge 1 commit intomainfrom
palette-ux-improvement-11727913379180764890

Conversation

@manupawickramasinghe
Copy link
Member

  • 💡 What: Added ic_content_copy drawable and applied it to the IP address TextView (textView6) in fragment_camera.xml. Also removed duplicate XML attributes that were causing build warnings/errors.
  • 🎯 Why: To make the copy-to-clipboard functionality more discoverable and intuitive for users. The XML cleanup fixes build issues.
  • 📸 Before/After: The IP address was just text with a tooltip. Now it has a copy icon next to it, matching the link color.
  • ♿ Accessibility: The copy action is now visually indicated, and the duplicate labelFor attributes were removed to ensure proper accessibility association. Preserved importantForAccessibility="no" on the decorative divider.

PR created automatically by Jules for task 11727913379180764890 started by @manupawickramasinghe

- Added `ic_content_copy.xml` vector drawable.
- Updated `fragment_camera.xml` to show the copy icon on the IP address TextView.
- Removed duplicate `android:labelFor` and `android:importantForAccessibility` attributes in `fragment_camera.xml`.
- Verified build passes with `./gradlew assembleDebug`.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant